8000 use tree locs directly rather than indirecting through `loc()` by froydnj · Pull Request #5776 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use tree locs directly rather than indirecting through loc() #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

use tree locs directly rather than indirecting through loc() #5776

merged 1 commit into from
May 10, 2022

Conversation

froydnj
Copy link
Contributor
@froydnj froydnj commented May 10, 2022 •
edited
Loading

Motivation

We already have the concrete tree in hand at these locations, we don't need to redirect back through the ExpressionPtr. This is slightly smaller code-wise and should be ever-so-slightly faster.

Test plan

See included automated tests.

@froydnj froydnj requested a review from a team as a code owner May 10, 2022 15:11
@froydnj froydnj requested review from jez and removed request for a team May 10, 2022 15:11
@froydnj froydnj merged commit 63664b1 into master May 10, 2022
@froydnj froydnj deleted the froydnj-local-vars-loc branch May 10, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @jez
0