8000 be less verbose when naming entry classes for the compiler's tables by froydnj · Pull Request #5767 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

be less verbose when naming entry classes for the compiler's tables #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2022
Merged

be less verbose when naming entry classes for the compiler's tables #5767

merged 1 commit into from
May 8, 2022

Conversation

froydnj
Copy link
Contributor
@froydnj froydnj commented May 8, 2022

Motivation

C++ classes provide fine scoping rules; we don't need to repeat ourselves.

Test plan

See included automated tests.

@froydnj froydnj requested a review from a team as a code owner May 8, 2022 00:36
@froydnj froydnj requested review from jez and removed request for a team May 8, 2022 00:36
@froydnj froydnj merged commit 41479d1 into master May 8, 2022
@froydnj froydnj deleted the froydnj-table-entry branch May 8, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @jez
0