8000 Stop sending notification about `# typed: false` file by jez · Pull Request #5720 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop sending notification about # typed: false file #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2022
Merged

Stop sending notification about # typed: false file #5720

merged 2 commits into from
Apr 29, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Apr 29, 2022

Motivation

We're going to go with #5716 only to show the user what's happening when they
attempt to jump-to-def in a typed: false file.

It turns out that VS Code will send textDocument/definition requests all over
the place as long as the user is holding down Cmd (not only once the click has
come through).

It sends the textDocument/definition request to see whether it can change a
piece of the source document to look like a blue link.

If it had been the case that VS Code just sent a request once the user had
committed to the request, it would have been easier to tell them why they were
getting no results.

Hopefully the hover message from #5716 will be enough to tell people what's
happening.

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner April 29, 2022 03:46
@jez jez requested review from elliottt and removed request for a team April 29, 2022 03:46
froydnj
froydnj reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor
@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also revert the position_assertions.cc changes that check for notifications in definitions and usages now that we no longer send these?

@jez
Copy link
Collaborator Author
jez commented Apr 29, 2022

Could you please also revert the position_assertions.cc changes that check for notifications in definitions and usages now that we no longer send these?

I was thinking that I would just let the test run to show the failures and then fix the failures, rather than also revert the changes to the test.

The test is fixed now.

elliottt
elliottt approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator
@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jez jez merged commit 8000928 into master Apr 29, 2022
@jez jez deleted the jez-hover-notif branch April 29, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj left review comments

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jez @elliottt @froydnj
0