8000 assert no notifications for typed files in some places by froydnj · Pull Request #5712 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

assert no notifications for typed files in some places #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

assert no notifications for typed files in some places #5712

merged 1 commit into from
Apr 28, 2022

Conversation

froydnj
Copy link
Contributor
@froydnj froydnj commented Apr 28, 2022

Motivation

Realized after working on #5709 that we can assert something about the notifications in typed files for defs and uses, which should help prevent some kinds of regressions.

Test plan

See included automated tests.

@froydnj froydnj requested a review from a team as a 8000 code owner April 28, 2022 12:13
@froydnj froydnj requested review from elliottt and removed request for a team April 28, 2022 12:13
@froydnj froydnj merged commit 00f9620 into master Apr 28, 2022
@froydnj froydnj deleted the froydnj-assert-no-notifications branch April 28, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @elliottt
0