Collapse duplicated error code 3506 #5652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
approved these changes
Apr 19, 2022
It looks like were reusing an error code. I considered making these into two separate error codes, but we're actually using `--suppress-error-code=3506` inside Sorbet, so I figured that splitting it into two error codes could potentially break something and I didn't want to have to deal with that on the off chance it happens. Luckily the two error codes were basically doing the same thing (`T::Enum` rewriter syntax) so I figured I'd just use the same ErrorClass for both.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It looks like were reusing an error code. I considered making these into
two separate error codes, but we're actually using
--suppress-error-code=3506inside Sorbet, so I figured that splittingit into two error codes could potentially break something and I didn't
want to have to deal with that on the off chance it happens.
Luckily the two error codes were basically doing the same thing
(
T::Enumrewriter syntax) so I figured I'd just use the sameErrorClass for both.
Test plan
n/a