8000 Rename some test files by jez · Pull Request #5625 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename some test files #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2022
Merged

Rename some test files #5625

merged 3 commits into from
Apr 16, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Apr 12, 2022

Motivation

I use names like test/testdata/infer/foo.rb and test/testdata/lsp/foo.rb a
lot while writing tests locally, before choosing a proper name.

We had some foo.rb files also in tests that had shorter names, which would
cause fzf to place them higher in the fuzzy search results. I think that
people never want to open these files, so I want to rename them.

Test plan

test-only changes

jez added 2 commits April 11, 2022 20:08
@jez
wip
b955a80
@jez
< 8000 div class="pr-1 flex-auto min-width-0" > wip
371fbfb
@jez jez requested a review from a team as a code owner April 12, 2022 03:13
@jez jez requested review from elliottt and removed request for a team April 12, 2022 03:13
@jez jez merged commit 469e779 into master Apr 16, 2022
@jez jez deleted the jez-foo branch April 16, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jez @elliottt
0