Flatten virtual package module into a series of casgns #5599
Conversation
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_LUmxBerksMB8br |
|
Stripe issues should be resolved as of https://go/ps/pull/444402 |
95fe893 to
188b129
Compare
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_LWRa0u9YrXig6L |
Changes the structure of the AST rewrite that is performed by the packager. Essentially, we remove all intermediate module declarations and replace them with fully-qualified casgns.
For details, see: before and after
Motivation
--stripe-packagesmode currently works poorly when a package namespace also corresponds to a class in the actual codebase (as opposed to a module). Essentially, it breaks when a nested-package is imported by a parent package that is also a class. Therefore, we replace module declarations with fully qualified casgns -- that way we do not redeclare any modules.As a side effect, this change also leads to a ~12% memory improvement in type-checking the Stripe codebase.
Runtime changes perhaps not statistically significant.
BEFORE
AFTER
Test plan
See included automated tests.
Tested on Stripe codebase.