8000 Revert "Defer sorting resolver todo lists until it matters" by jez · Pull Request #5553 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Defer sorting resolver todo lists until it matters" #5553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

Revert "Defer sorting resolver todo lists until it matters" #5553

merged 1 commit into from
Mar 31, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Mar 31, 2022

Reverts #5527

@jez jez requested a review from a team as a code owner March 31, 2022 16:19
@jez jez requested review from froydnj and removed request for a team March 31, 2022 16:19
@jez
Copy link
Collaborator Author
jez commented Mar 31, 2022

This started reporting nondeterministic error counts if there were errors

froydnj
froydnj approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor
@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who needs deterministic errors anyway? 🙂

@jez jez enabled auto-merge (squash) March 31, 2022 16:22
@jez jez merged commit 270767d into master Mar 31, 2022
@jez jez deleted the revert-5527-jez-defer-sort branch March 31, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj approved these changes

@Morriar Morriar Morriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jez @froydnj @Morriar
0