8000 Add T::Enumerator::Lazy (requires static and runtime bump!) by jez · Pull Request #5552 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add T::Enumerator::Lazy (requires static and runtime bump!) #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

Add T::Enumerator::Lazy (requires static and runtime bump!) #5552

merged 1 commit into from
Mar 31, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Mar 31, 2022

Motivation

Fixes #3028

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner March 31, 2022 07:41
@jez jez requested review from aprocter and removed request for a team March 31, 2022 07:41
@jez jez changed the title Add T::Enumerator::Lazy Add T::Enumerator::Lazy (requires static and runtime bump!) Mar 31, 2022
@jez jez force-pushed the jez-enumerator-lazy branch from 1cb0de6 to fdcc4fa Compare March 31, 2022 07:44
@froydnj
Copy link
Contributor
froydnj commented Mar 31, 2022

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_LQGSdazhe0RGD7
→ https://go/builds/bui_LQGSBcA0flzCFp

@aprocter aprocter requested review from froydnj and removed request for aprocter March 31, 2022 17:10
froydnj
froydnj approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor
@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me!

@jez jez merged commit df7457a into master Mar 31, 2022
@jez jez deleted the jez-enumerator-lazy branch March 31, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froydnj froydnj froydnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: undefined method `[]' for Enumerator::Lazy:Class
2 participants
@jez @froydnj
0