8000 make `TypePtr` parameter passing more idiomatic in `TypeErrorDiagnostics` by froydnj · Pull Request #5540 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make TypePtr parameter passing more idiomatic in TypeErrorDiagnostics #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

make TypePtr parameter passing more idiomatic in TypeErrorDiagnostics #5540

merged 2 commits into from
Mar 30, 2022

Conversation

froydnj
Copy link
Contributor
@froydnj froydnj commented Mar 30, 2022

Motivation

Per the tin. This is error code, so we don't really care about copying the TypePtrs, but still.

Test plan

See included automated tests.

@froydnj froydnj requested a review from a team as a code owner March 30, 2022 19:11
@froydnj froydnj requested review from elliottt and removed request for a team March 30, 2022 19:11
@froydnj froydnj enabled auto-merge (squash) March 30, 2022 19:20
@froydnj froydnj removed the request for review from elliottt March 30, 2022 19:21
@froydnj froydnj merged commit 455cdf9 into master Mar 30, 2022
@froydnj froydnj deleted the froydnj-explain-type-mismatch-parameters branch March 30, 2022 19:27
aprocter pushed a commit that referenced this pull request Mar 31, 2022
@froydnj @aprocter
make TypePtr parameter passing more idiomatic in `TypeErrorDiagnost…
eb1b34a 
…ics` (#5540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @jez
0