Fix runtime exception with unused optional and rest parameters. #5475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'm testing this change on Stripe's codebase to see if anything breaks. I'll let you know the results, and merge if it passes. |
paracycle
reviewed
Mar 16, 2022
Comment on lines
+185
to
+188
| rest_count = args_length - @arg_types.length | ||
| rest_count = 0 if rest_count.negative? | ||
|
|
||
| arg_types += [[@rest_name, @rest_type]] * rest_count |
There was a problem hiding this comment.
This could just be:
Suggested change
| rest_count = args_length - @arg_types.length | |
| rest_count = 0 if rest_count.negative? | |
| arg_types += [[@rest_name, @rest_type]] * rest_count | |
| rest_count = (args_length - @arg_types.length).clamp(0..nil) | |
| arg_types += [[@rest_name, @rest_type]] * rest_count |
by the way, or:
Suggested change
| rest_count = args_length - @arg_types.length | |
| rest_count = 0 if rest_count.negative? | |
| 8000 | |
| arg_types += [[@rest_name, @rest_type]] * rest_count | |
| rest_count = [args_length - @arg_types.length, 0].max | |
| arg_types += [[@rest_name, @rest_type]] * rest_count |
There was a problem hiding this comment.
ah, i don't mind the code being written either way and i already tested the code as written on Stripe's codebase, so i'm inclined to ship it as is (lest by some oversight the two aren't as equivalent as we think they are).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an exception that occurs in sorbet-runtime when a method that accepts both optional and rest/splat parameters is called with neither.
Motivation
Given a typed method definition such as:
If the method is called with no parameters, an ArgumentError will be raised at
sorbet/gems/sorbet-runtime/lib/types/private/methods/signature.rb
Line 185 in 5897a44
due to
(args_length - @arg_types.length)being negative.This PR constrains the above result to a minimum of zero, in which case nothing is added to
arg_types.Test plan
See included automated tests.