8000 Recover from unclosed block args pipe by jez · Pull Request #5284 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Recover from unclosed block args pipe #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 10, 2022
Merged

Recover from unclosed block args pipe #5284

merged 9 commits into from
Feb 10, 2022

Conversation

jez
Copy link
Collaborator
@jez jez commented Feb 10, 2022

Motivation

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner February 10, 2022 18:38
@jez jez requested review from aprocter and removed request for a team February 10, 2022 18:38
@jez jez force-pushed the jez-block-args-pipe branch from 2c51867 to a1a6116 Compare February 10, 2022 18:45
jez added 9 commits February 10, 2022 11:34
@jez
Error recovery for case
bed8b08
@jez
Add gaps
17ecc56
@jez
Remove dead Builder.cc code
e423310
@jez
Track lineStart in bison locations
b6a3aed
@jez
wip: Checkpoint
a487c62
@jez
Use indentation when attempting to recover
a0a315f 
This lets us handle everything in the new 3 and 4 tests, at the cost of
not being able to handle some things in 2 anymore.
@jez
Add assertions to new tests
2fbd358
@jez
Fix failing circular argument reference test
fc480e4 
This test is t
8000
elling me that DIAGCHECK is orthogonal to good parses, and
we should replace every usage of it we see with a call to `error_node` +
let the parse continue.
@jez
Fix failing forward_args_invalid tests
a199571 
This just makes the error message identical to what it was.
@jez jez force-pushed the jez-block-args-pipe branch from a1a6116 to a199571 Compare February 10, 2022 19:34
Base automatically changed from jez-case to master February 10, 2022 19:58
@jez jez merged commit 132aebd into master Feb 10, 2022
@jez jez deleted the jez-block-args-pipe branch February 10, 2022 20:22
@jez jez added this to the Better Parser milestone Feb 11, 2022
@jez jez mentioned this pull request Feb 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprocter aprocter aprocter approved these changes

Assignees
No one assigned
Labels
None yet
4691
Projects
None yet
Milestone
Better Parser
Development

Successfully merging this pull request may close these issues.
2 participants
@jez @aprocter
0