8000 Upgrade Bazel to 5.0.0 by vinistock · Pull Request #5279 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade Bazel to 5.0.0 #5279

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2022
Merged

Upgrade Bazel to 5.0.0 #5279

merged 2 commits into from
Feb 10, 2022

Conversation

vinistock
Copy link
Collaborator

This is part of the work for compiling Sorbet on M1 macs

Upgrade Bazel to 5.0.0.

Motivation

The earlier version don't have some darwin_arm64 rules related to toolchains which prevents us from compiling to ARM64.

Test plan

Existing tests should cover it.

@vinistock vinistock requested a review from a team as a code owner February 9, 2022 20:57 8000
@vinistock vinistock requested review from elliottt and removed request for a team February 9, 2022 20:57
@vinistock vinistock added this to the Sorbet on Apple Silicon milestone Feb 9, 2022
elliottt
elliottt approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator
@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for doing the upgrade!

@elliottt elliottt enabled auto-merge (squash) February 9, 2022 21:25
@elliottt elliottt disabled auto-merge February 9, 2022 21:25
@elliottt
Copy link
Collaborator
elliottt commented Feb 9, 2022

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR. When the build
finishes, I'll share with you whether or how it failed. Thanks!

Stripe employees can see the build results here:

→ https://go/builds/bui_L7cxyizeG57Vlq
→ https://go/builds/bui_L7cx66nSPWnhe9

@elliottt
Copy link
Collaborator
elliottt commented Feb 9, 2022

This failed in Stripe's CI due to inherited bazelrc options. We'll need to fix that before we can land this.

@elliottt
Copy link
Collaborator

Stripe build fix PR: https://go/ps/pull/418401

@elliottt elliottt merged commit e1756f4 into sorbet:master Feb 10, 2022
@vinistock vinistock deleted the upgrade_bazel branch February 10, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sorbet on Apple Silicon
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @elliottt
0