More indentation-aware changes #5275

jez · 2022-02-09T01:11:15Z

See included automated tests.

I noticed that there's an overload of this which lets us use less boilerplate.

jez requested a review from a team as a code owner February 9, 2022 01:11

jez requested review from aprocter and removed request for a team February 9, 2022 01:11

jez force-pushed the jez-better-parser branch from 4d54227 to 44e274c Compare February 9, 2022 03:13

jez force-pushed the jez-do-end branch 3 times, most recently from e730690 to 6c5e833 Compare February 10, 2022 04:23

aprocter approved these changes Feb 10, 2022

View reviewed changes

Base automatically changed from jez-better-parser to master February 10, 2022 18:42

jez added 7 commits February 10, 2022 10:43

no-op: Simplify some logic

79dc7b1

I noticed that there's an overload of this which lets us use less boilerplate.

begin, unless, while, until, lambda do, block do, normal do

338fc95

Slightly change this error message for if

9fc1bb6

Do the same thing for while, unless, until

069f82d

Add test

58af403

Add another test with more block forms

c48bdc1

Add a test with begin + rescue

ae88a6d

jez force-pushed the jez-do-end branch from 6c5e833 to ae88a6d Compare February 10, 2022 18:45

Fix semantic conflict in missing_operator test

2bd0815

jez enabled auto-merge (squash) February 10, 2022 19:05

jez merged commit 3e48ce0 into master Feb 10, 2022

jez deleted the jez-do-end branch February 10, 2022 19:33

jez added this to the Better Parser milestone Feb 11, 2022

jez mentioned this pull request Mar 6, 2022

Bug in Sorbet parser: while inside begin/rescue block #5419

Closed

Provide feedback