Allow eof everywhere kEND is allowed #5183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge hack, but it appears to maybe work ok in practice.
I couldn't get this to work with the `# error:` assertions, because it was fiddly with the end-of-file handling
This is an artifact of how it works right now: every time the kend_or_eof rule reduces, it'll add another error. So if it reduces multiple times because there are multiple `kEND` tokens missing, each one will get a new error. It's kind of weird, and we could attempt to dedup, but honestly it seems kind of not terrible.
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_L2YKAcXt8aCMoM |
|
#5000 superceded this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a huge hack, but it appears to maybe work okay in practice.
Test plan
See included automated tests.