8000 Import tests for numbered parameters by Morriar · Pull Request #4253 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Import tests for numbered parameters #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

Morriar
Copy link
Collaborator
@Morriar Morriar commented Jun 9, 2021

Motivation

No functional change here, just importing the new tests related to numbered parameters that were already implemented in #3344.

Test plan

See included automated tests.

cc. @vinistock

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Vinicius Stock <vinicius.stock@shopify.com>
8000 @Morriar Morriar requested a review from a team as a code owner June 9, 2021 18:16
@Morriar Morriar requested review from jez and removed request for a team June 9, 2021 18:16
Copy link
Collaborator
@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jez jez enabled auto-merge (squash) June 9, 2021 18:16
@jez jez merged commit 83856fd into sorbet:master Jun 9, 2021
@Morriar Morriar deleted the at-ruby27-numbered-params branch June 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0