8000 s/TEST_DATA/test_data/ to avoid warnings about multiply-initialized constants by froydnj · Pull Request #4259 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

s/TEST_DATA/test_data/ to avoid warnings about multiply-initialized constants #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

s/TEST_DATA/test_data/ to avoid warnings about multiply-initialized constants #4259

merged 1 commit into from
Jun 10, 2021

Conversation

froydnj
Copy link
Contributor
@froydnj froydnj commented Jun 10, 2021

Motivation

I am getting tired of the warnings that appear when I run tests:

# Running:

....................................................................................................................................................................................................................S................................................................................................................................................................................................................................................................................................/home/froydnj/src/sorbet/gems/sorbet-runtime/test/types/method_validation.rb:141: warning: already initialized constant Opus::Types::Test::MethodValidationTest::TEST_DATA
/home/froydnj/src/sorbet/gems/sorbet-runtime/test/types/method_validation.rb:179: warning: previous definition of TEST_DATA was here
......................................................................................................................................................................................................................................................................

This change makes them go away:

# Running:

..........................................................................................................................................................................................................................................................................................................................................................................................................................................................S.................................................................................................................................................................................................................................................................................................................................

Test plan

See included automated tests.

@froydnj froydnj requested a review from a team as a code owner June 10, 2021 18:31
@froydnj froydnj requested review from aprocter-stripe and removed request for a team June 10, 2021 18:31
@froydnj froydnj merged commit 6af2ced into master Jun 10, 2021
@jez jez deleted the froydnj-fix-test-data-warning branch May 31, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jez jez jez approved these changes

@aprocter-stripe aprocter-stripe Awaiting requested review from aprocter-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @jez
0