8000 add T::Configuration.*vm_prop_serde* methods to t.rbi by froydnj · Pull Request #4190 · sorbet/sorbet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add T::Configuration.*vm_prop_serde* methods to t.rbi #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

add T::Configuration.*vm_prop_serde* methods to t.rbi #4190

merged 1 commit into from
Apr 30, 2021

Conversation

froydnj
Copy link
Contributor
@froydnj froydnj commented Apr 30, 2021

Motivation

Discovered that I forgot to add these; without them, using them fails Sorbet typechecking.

Test plan

See included automated tests.

@froydnj froydnj requested a review from a team as a code owner April 30, 2021 20:20
@froydnj froydnj requested review from elliottt and removed request for a team April 30, 2021 20:20
@froydnj froydnj merged commit 4e4baac into master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froydnj @elliottt
0