feat: support namespace arg for show bfd commands #3885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aa69ec7 to
5e830dd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6116fcf to
f15a964
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to 202505: #3892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the namespace support for
show bfd summary&show bfd peer <peer_id>command. For example, users can runshow bfd summary -n asic0,show bfd peer 10.0.1.1 -n asic0and etc.How I did it
How to verify it
Run
show bfd summary -n <namespace>andshow bfd peer <peer_id> -n <namespace>and verify the outputPrevious command output (if the output of a command-line utility has changed)
Nothing has changed to the output of these 2 commands, we are only adding the namespace argument support in this PR. Users can still use the
sudo ip netns exec asicX ...way after this PR.I confirmed the output of
sudo ip netns exec asicX show bfd summaryandshow bfd summary -n asicXare the same, andsudo ip netns exec asicX show bfd peer <peer_id>andshow bfd peer <peer_id> -n asicXare the sameNew command output (if the output of a command-line utility has changed)
Nothing has changed to the output of these 2 commands, we are only adding the namespace argument support in this PR. Users can still use the
sudo ip netns exec asicX ...way after this PR.I confirmed the output of
sudo ip netns exec asicX show bfd summaryandshow bfd summary -n asicXare the same, andsudo ip netns exec asicX show bfd peer <peer_id>andshow bfd peer <peer_id> -n asicXare the same