HLD for SmsrtSwitch DPU graceful shutdown #1991
Conversation
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
|
||
| ### 1. Host-side Named Pipe | ||
|
|
||
| A named pipe (e.g., `/var/run/gnoi_reboot.pipe`) is created on the host. It acts as a one-way communication channel from PMON to the host. |
There was a problem hiding this comment.
What is the benefit of using pipes instead of using the DB for the communication channel between daemons? SONiC has a well-tested publisher/subscriber implementation used throughout the system.
There was a problem hiding this comment.
@oleksandrivantsiv We will be using Redis, the benefits are captured in the document.
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
@rameshraghupathy As discussed in the community meeting call, could you update HLD with state transition flag. Fail the command if the flag is already set. Thanks!
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
|
||
| <p align="center"><img src="./images/reboot-interoperability.svg"></p> | ||
|
|
||
| The diagram above illustrates two scenarios where both module_base.py and smartswitch_reboot_helper might attempt to initiate a shutdown and reboot simultaneously. By utilizing the shared RedisDB table GNOI_REBOOT_REQUEST, the system ensures that only the first trigger is honored, and subsequent attempts during an ongoing reboot are effectively ignored. |
There was a problem hiding this comment.
This is one of the approaches. But we can do this by reading the transition_in_progress flag by reboot script, right? which one is simple and better?
There was a problem hiding this comment.
@vvolam Actually it is not just that. More details on how will this be handled is provided in the senarios section last statement. Let me rephrase it and update you.
HLD for SmsrtSwitch DPU graceful shutdown
Related PRs:
sonic-net/sonic-platform-common#567
sonic-net/sonic-host-services#255