fix: show allocated resources in TaskStatus #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8076289 to
67e8110
Compare
antmat
requested changes
Aug 31, 2018
insonmnia/resource/pool.go
Outdated
| defer m.mu.Unlock() | ||
| res, ok := m.pool.used[id] | ||
| if !ok { | ||
| return nil, fmt.Errorf("failed to get resources") |
There was a problem hiding this comment.
return nil, fmt.Errorf("failed to get resources for task %s: no such task", id)
insonmnia/resource/pool.go
Outdated
| func (m *Scheduler) ResourceByTask(id string) (*sonm.AskPlanResources, error) { | ||
| m.mu.Lock() | ||
| defer m.mu.Unlock() | ||
| res, ok := m.pool.used[id] |
There was a problem hiding this comment.
this one is global pool for ask plans. You need to do smth like
ask, ok := m.taskToAskPlan[id]
//check ok
pool, ok := m.askPlanPools[ask.GetId()]
//check ok
res, ok := pool.used[id]
added 2 commits
August 31, 2018 13:54
This commit fills the `AllocatedResources` field from the deal's ask-plan. Actual resources info gives an ability to show what part of deal's resources are acquired by task, at least what GPUs is used.
4ba0a49 to
062919b
Compare
antmat
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fills the
AllocatedResourcesfield from the deal's ask-plan.Actual resources info gives an ability to show what part of deal's resources are acquired by task, at least what GPUs is used.