fix: load keystore even if --insecure flag is set
#1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a problem when `--insecure` flag is used with the CLI and some sub-command wants to load a key or obtain a default eth address from the key store. Therefore, now we'll load keystore prematurely for any command. Now if insecure mode is activated, only TLS credentials creation will be skipped for gRPC's client connection.
33c445f to
2ca627e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a problem when
--insecureflag is usedwith the CLI and some sub-command wants to load a key or
obtain a default eth address from the key store.
Therefore, now we'll load keystore prematurely for any command.
Now if insecure mode is activated, only TLS credentials creation
will be skipped for gRPC's client connection.