8000 feat: gaslimits in api by quasisamurai · Pull Request #1200 · sonm-io/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: gaslimits in api #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers 8000 and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2018
Merged

feat: gaslimits in api #1200

merged 5 commits into from
Jul 20, 2018

Conversation

quasisamurai
Copy link
Collaborator

No description provided.

@quasisamurai quasisamurai requested a review from a team as a code owner July 13, 2018 13:31
@quasisamurai quasisamurai added the T: WIP This PR/Issue still in progress label Jul 13, 2018
sokel
sokel reviewed Jul 13, 2018
View reviewed changes
Copy link
Member
@sokel sokel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please calculate gas limit with +20% overcharge for safe execution.

blockchain/gasLimits.go Outdated
package blockchain

const (
transferGaslimit = 50000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too few, mb 70k

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit need to be uppercase

blockchain/gasLimits.go Outdated
increaseApprovalGasLimit = 60000
decreaseApprovalGasLimit = 60000
approveGasLimit = 60000
placeOrderGasLimit = 550000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too few

blockchain/gasLimits.go Outdated
billGasLimit = 300000
createChangeRequestGasLimit = 250000
cancelChangeRequestGasLimit = 150000
registerWorkerGasLimit = 100000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too few

@quasisamurai quasisamurai added the S: Blockchain This PR/Issue changes Blockchain API label Jul 13, 2018
@quasisamurai quasisamurai force-pushed the feat/gas-limits branch 3 times, most recently from 46dd519 to acfa192 Compare July 13, 2018 14:24
@quasisamurai quasisamurai requested a review from nikonov1101 July 13, 2018 14:55
@sokel sokel removed the T: WIP This PR/Issue still in progress label Jul 20, 2018
@quasisamurai quasisamurai merged commit 71c540b into master Jul 20, 2018
@quasisamurai quasisamurai deleted the feat/gas-limits branch July 20, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokel sokel sokel approved these changes

@nikonov1101 nikonov1101 Awaiting requested review from nikonov1101

Assignees
No one assigned
Labels
S: Blockchain This PR/Issue changes Blockchain API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quasisamurai @sokel
0