feat: make masterchain gas price configurable #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Hren
requested changes
Jul 13, 2018
blockchain/config.go
Outdated
| @@ -13,6 +13,7 @@ type Config struct { | |||
| SidechainEndpoint url.URL | |||
| ContractRegistryAddr common.Address | |||
| BlocksBatchSize uint64 | |||
| MasterchainGasPrice int64 | |||
etc/node.yaml
Outdated
| blockchain: | ||
| # gas price for masterchain transactions, in wei | ||
| # default is 20 Gwei | ||
| masterchain_gas_price: 20000000000 |
There was a problem hiding this comment.
Wouldn't it better to write directly "20Gwei" instead, like we do in duration fields?
e415c21 to
55970a8
Compare
Merged
d86d3c6 to
6ebb878
Compare
This option now usefull for `deposit` and gatekeeper `withdraw` ;
6ebb878 to
427441d
Compare
9ed1bca to
8edef1f
Compare
8edef1f to
e86d71d
Compare
nikonov1101
requested changes
Jul 25, 2018
| gasLimit: defaultMasterchainGasLimit, | ||
| endpoint: defaultMasterchainEndpoint, | ||
| logParsePeriod: defaultLogParsePeriod, | ||
| blockConfirmations: defaultBlockConfirmations, | ||
| }, | ||
| sidechain: &chainOpts{ | ||
| gasPrice: defaultSidechainGasPrice, | ||
| gasPrice: big.NewInt(0).SetUint64(defaultSidechainGasPrice), |
There was a problem hiding this comment.
big.NewInt(defaultSidechainGasPrice)
antmat
approved these changes
Jul 25, 2018
3Hren
approved these changes
Jul 25, 2018
nikonov1101
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option now usefull for
depositand gatekeeperwithdraw;If option not defined gas price is determined by the latest blocks median gas price.