fix: handle temporary network errors in Relay #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when Relay server finished accepting new connections when a temporary error occurs, such as EMFILE. Now it will sleep for some period of time, but still interrupting on non-recoverable error. Also the entire server now will stop on such non-recoverable errors instead of waiting for interruption signal.
antmat
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when Relay server finished accepting new connections when a temporary error occurs, such as EMFILE.
Now it will sleep for some period of time, but still interrupting on non-recoverable error. This is the same how gRPC handles this.
Also the entire server now will stop on such non-recoverable errors instead of waiting for interruption signal.