proposal: better error handling for the cli #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good. Do more. |
antmat
requested changes
Jul 2, 2018
fbc1e38 to
655342c
Compare
25b3471 to
c7101b4
Compare
This commit changes CLI behavior in the following way: 1. Using RunE instead of Run for each cobra command. 2. Setting SilenceUsage = true, if not - cli will print help usage on every error. 3. Setting SilenceErrors = true, if not - cli will show their own error and then handle out custom code that controls the os.Exit status. 4. Introducing `newCmd` and `newCmdWithKeys` wrappers. The first one is used to wrapping cobra.Command with `SilenceUsage` and `SilenceErrors` flags. The second one is used to wrapping command with the key loading code (if required and not handled externally). 5. Removed all of `os.Exit(1)` calls, excepts only one that handles single point of error handling now.
antmat
reviewed
Jul 3, 2018
cmd/cli/commands/blacklist.go
Outdated
| Short: "Manage blacklisted addresses", | ||
| Use: "blacklist", | ||
| Short: "Manage blacklisted addresses", | ||
| PersistentPostRunE: loadKeyStoreIfRequired, |
c7101b4 to
d7b5b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes CLI behavior in the following way:
newCmdandnewCmdWithKeyswrappers. The first one is used to wrapping cobra.Command withSilenceUsageandSilenceErrorsflags. The second one is used to wrapping command with the key loading code (if required and not handled externally).os.Exit(1)calls, excepts only one that handles single point of error handling now.