10000 feat: deployment scripts for livenet by quasisamurai · Pull Request #1087 · sonm-io/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: deployment scripts for livenet #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 13, 2018
Merged

feat: deployment scripts for livenet #1087

merged 9 commits into from
Jul 13, 2018

Conversation

quasisamurai
Copy link
Collaborator

Here is human-readable deployment scripts for livenet.
Will add comments and listing tomorrow

@quasisamurai quasisamurai requested a review from a team as a code owner June 26, 2018 18:48
@quasisamurai quasisamurai added T: WIP This PR/Issue still in progress T: feature This PR/Issue adds a new feature P: low This PR/Issue has minor priority V: major This PR/Issue required major version to be bumped S: Smart-contracts This PR/Issue changes SC labels Jun 26, 2018
@3Hren
Copy link
Member
3Hren commented Jun 26, 2018

So javascript.

sokel
sokel requested changes Jun 27, 2018
View reviewed changes
blockchain/source/live-deploy-scripts/1_deploy_live_gate.js Outdated
@@ -0,0 +1,19 @@
var GateMultisig = artifacts.require('./MultiSigWallet.sol');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use let instead of var

blockchain/source/live-deploy-scripts/1_deploy_live_gate.js Outdated
var MSOwners = ['0x0', '0x0'];
var MSRequired = 1;
var SNMAddress = '0x983f6d60db79ea8ca4eb9968c6aff8cfa04b3c63';
var freezingTime = 30;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let it be 15 * 60

blockchain/source/live-deploy-scripts/2_deploy_sidechain_gate.js Outdated

var MSOwners = ['0x34', '0x35'];
var MSRequired = 1;
var freezingTime = 30;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let it be 15 * 60

@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch 2 times, most recently from 1a3b858 to fb6249c Compare June 28, 2018 09:57
@quasisamurai quasisamurai added P: HIGH This PR/Issue has the high priority and removed T: WIP This PR/Issue still in progress labels Jun 28, 2018
@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch 6 times, most recently from e8888cc to 7f8ee6f Compare June 28, 2018 14:12
sokel
sokel previously approved these changes Jun 28, 2018
View reviewed changes
@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch from 019fdbd to a35d975 Compare June 28, 2018 18:53
@quasisamurai quasisamurai removed the P: low This PR/Issue has minor priority label Jun 28, 2018
@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch from a35d975 to 07c7d9c Compare June 28, 2018 19:15
sokel
sokel previously approved these changes Jun 28, 2018
View reviewed changes
@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch 2 times, most recently from 8d44e52 to d38c76d Compare June 29, 2018 15:55
@3Hren 3Hren added the T: WIP This PR/Issue still in progress label Jun 30, 2018
@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch from d38c76d to 972520e Compare July 9, 2018 10:01
@quasisamurai quasisamurai force-pushed the feat/deploy-scripts branch from 972520e to e458bfa Compare July 9, 2018 10:15
@quasisamurai quasisamurai removed the T: WIP This PR/Issue still in progress label Jul 9, 2018
@nikonov1101
Copy link
Member

Hey @sokel @quasisamurai, any updates here? Is it ready to merge?

@quasisamurai quasisamurai mentioned this pull request Jul 13, 2018
Open
@sokel sokel merged commit edee592 into master Jul 13, 2018
@sokel sokel deleted the feat/deploy-scripts branch July 13, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokel sokel sokel approved these changes

Assignees
No one assigned
Labels
P: HIGH This PR/Issue has the high priority S: Smart-contracts This PR/Issue changes SC T: feature This PR/Issue adds a new feature V: major This PR/Issue required major version to be bumped
4B03
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quasisamurai @3Hren @nikonov1101 @sokel
0