8000 fix: proper error type in ErrorOrNil by antmat · Pull Request #1847 · sonm-io/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: proper error type in ErrorOrNil #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

fix: proper error type in ErrorOrNil #1847

merged 1 commit into from
Jan 31, 2019

Conversation

antmat
Copy link
Collaborator
@antmat antmat commented Jan 31, 2019

Fixxed bug with task cancellation:

  • process ask-plan which are pending for deletion in a usual pipeline to update order info in case ask-plan can not be deleted right now
  • return proper type from ErrorOrNil function to fix this https://golang.org/doc/faq#nil_error behaviour

@antmat antmat merged commit ce9291f into master Jan 31, 2019
@3Hren 3Hren deleted the fix/proper_multierror_on_task_removal branch January 31, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3Hren 3Hren Awaiting requested review from 3Hren 3Hren is a code owner

@nikonov1101 nikonov1101 Awaiting requested review from nikonov1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antmat
0