This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rpc: getProgramAccounts, restrict base58 account data size #18852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18852 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 443 443
Lines 126082 126089 +7
=========================================
- Hits 104507 104493 -14
- Misses 21575 21596 +21 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2021
* Refactor account encoding to povide helper w/out querying Bank * Use new method in get_program_accounts to properly return length err (cherry picked from commit 3eecb6f)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The rpc
getProgramAccountsmethod does not consider account data size when using base58, even though the docs say it does.Summary of Changes
Refactor account-encoding method to use in program-accounts loop (also needed for #18624 ); get base58 account-size error for free.
Fixes #18839