8000 feat(rpc): Implement Transfer Action Endpoint with Actions Specification by onyedikachi-david · Pull Request #37 · solana-foundation/kora · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(rpc): Implement Transfer Action Endpoint with Actions Specification #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(rpc): Implement Transfer Action Endpoint with Actions Specification #37

wants to merge 2 commits into from
+195 −0

Conversation

onyedikachi-david
Copy link
@onyedikachi-david onyedikachi-david commented Mar 5, 2025 •
edited
Loading

Closes #16

Changes

  • Added /api/actions/transfer GET endpoint that returns action metadata
  • Added /api/actions/transfer POST endpoint that processes transfer requests
  • Implemented action specification format with:
    • Action type, icon, title, and description
    • Required parameters (amount, token, destination)
    • Proper error handling and response formatting
  • Reused existing transfer transaction logic for consistency
  • Added comprehensive tests for both endpoints.
    This pull request was created for https://app.gib.work/bounties/4fcf8fb1-e80c-4a37-9eb8-a4e6f0651e3a in an attempt to solve a bounty [BOUNTY] Add action for transfer #16 . Payment for the bounty is immediately sent to the contributor after merge.

@onyedikachi-david
feat: Add transfer action RPC methods and schema
65b6783 
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
@onyedikachi-david
Copy link
Author
image

@gitteri
Copy link
Collaborator
gitteri commented Mar 7, 2025

I'm not able to reproduce a working action w/dialect. did you have to do anything to make this work?

Some other things that need attention:

  • OPTIONS response
  • Following the full actions spec: It doesn't seem like the POST request follows the required spec
  • actions.json file
  • API endpoint that responds properly to get/post api requests -- you're currently just using the rpc protocol

@onyedikachi-david
Copy link
Author

I'm not able to reproduce a working action w/dialect. did you have to do anything to make this work?

Some other things that need attention:

  • OPTIONS response
  • Following the full actions spec: It doesn't seem like the POST request follows the required spec
  • actions.json file
  • API endpoint that responds properly to get/post api requests -- you're currently just using the rpc protocol

I have all these working in some updates that I'm yet to push. the only issue I'm having is the POST, it works when I use curl but doesn't work when I submit the form on the browser. I keep getting a parser error. I hope to resolve it by the end of the day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BOUNTY] Add action for transfer
2 participants
@onyedikachi-david @gitteri
0