8000 Fix jira_get_issue tool to include comments when requested with comment_limit by sooperset · Pull Request #281 · sooperset/mcp-atlassian · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix jira_get_issue tool to include comments when requested with comment_limit #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Fix jira_get_issue tool to include comments when requested with comment_limit #281

merged 1 commit into from
Apr 17, 2025

Conversation

sooperset
Copy link
Owner

Description

This PR fixes an issue with the jira_get_issue tool where comments were being fetched from the Jira API but filtered out of the final response even when explicitly requested with comment_limit > 0. The bug was due to a field name mismatch in the serialization logic.

Fixes: #275

Changes

  • Fixed JiraIssue.to_simplified_dict() to check for "comment" (singular) instead of "comments" (plural) to match the field name used in the requested_fields list
  • Added integration test test_jira_get_issue_includes_comments to verify that comments are included when requested with comment_limit > 0

Testing

  • Unit tests added/updated
  • Integration tests passed
  • Manual checks performed: [Verified that comments appear in the jira_get_issue response when comment_limit>0 is specified]

Checklist

  • Code follows project style guidelines (linting passes).
  • Tests added/updated for changes.
  • All tests pass locally.
  • Documentation updated (if needed).

@sooperset
Fix jira_get_issue tool to include comments when comment_limit>0
675ae50 
Change field name check from "comments" to "comment" in JiraIssue.to_simplified_dict()
to match the field name in requested_fields list. Added test to verify comments
are included in the response when comment_limit is set.

Fixes #275
@sooperset sooperset merged commit cf66418 into main Apr 17, 2025
4 checks passed
@sooperset sooperset deleted the fix/issue-275-jira-get-issue-comments branch April 17, 2025 16:52
@sooperset sooperset mentioned this pull request Apr 17, 2025
Closed
2 tasks
cutekibry pushed a commit to cutekibry/mcp-atlassian that referenced this pull request Apr 21, 2025
@sooperset
Fix jira_get_issue tool to include comments when comment_limit>0 (soo…
d9e655e 
…perset#281)

Change field name check from "comments" to "comment" in JiraIssue.to_simplified_dict()
to match the field name in requested_fields list. Added test to verify comments
are included in the response when comment_limit is set.

Fixes sooperset#275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: While we can Add comments to jira issues there is no get comments function to retrieve them
1 participant
@sooperset
0