10000 Fix logger factory lazy initialization problem by alaneuler · Pull Request #133 · sofastack/sofa-common-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix logger factory lazy initialization problem #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2021
Merged

Fix logger factory lazy initialization problem #133

merged 4 commits into from
Mar 3, 2021

Conversation

alaneuler
Copy link
Contributor

No description provided.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/L labels Mar 3, 2021
HzjNeverStop
HzjNeverStop approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor
@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #133 (d8eec3b) into master (115f325) will increase coverage by 0.65%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
+ Coverage     30.10%   30.76%   +0.65%     
- Complexity      573      584      +11     
============================================
  Files            73       73              
  Lines          5191     5200       +9     
  Branches       1006     1009       +3     
============================================
+ Hits           1563     1600      +37     
+ Misses         3441     3408      -33     
- Partials        187      192       +5
Impacted Files Coverage Δ Complexity Δ
.../com/alipay/sofa/common/log/proxy/LoggerProxy.java 8.54% <ø> (+1.70%) 4.00 <0.00> (+1.00)
...sofa/common/log/proxy/TemporaryILoggerFactory.java 100.00% <ø> (+16.66%) 4.00 <0.00> (+1.00)
.../common/log/proxy/TemporaryILoggerFactoryPool.java 37.14% <ø> (+37.14%) 2.00 <0.00> (+2.00)
...ay/sofa/common/log/MultiAppLoggerSpaceManager.java 47.61% <85.71%> (+10.11%) 17.00 <2.00> (+5.00)
...com/alipay/sofa/common/log/LoggerSpaceManager.java 50.00% <100.00%> (ø) 6.00 <1.00> (ø)
...main/java/com/alipay/sofa/common/log/LogSpace.java 80.00% <0.00%> (-5.00%) 8.00% <0.00%> (-1.00%)
...log/factory/AbstractLoggerSpaceFactoryBuilder.java 83.16% <0.00%> (+0.99%) 24.00% <0.00%> (+1.00%)
...va/com/alipay/sofa/common/log/env/LogEnvUtils.java 58.53% <0.00%> (+1.21%) 20.00% <0.00%> (+1.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115f325...d8eec3b. Read the comment docs.

@alaneuler alaneuler merged commit ab31e20 into sofastack:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HzjNeverStop HzjNeverStop HzjNeverStop approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaneuler @codecov-io @HzjNeverStop
0