8000 Support auto transform SOFATracer Span in SOFA ThreadPool by HzjNeverStop · Pull Request #190 · sofastack/sofa-common-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support auto transform SOFATracer Span in SOFA ThreadPool #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

HzjNeverStop
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@codecov
Copy link
codecov bot commented Sep 26, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e0ff800) 34.69% compared to head (aab291a) 35.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
+ Coverage     34.69%   35.05%   +0.36%     
- Complexity      672      689      +17     
============================================
  Files            74       75       +1     
  Lines          5693     5745      +52     
  Branches       1094     1097       +3     
============================================
+ Hits           1975     2014      +39     
- Misses         3466     3473       +7     
- Partials        252      258       +6     
Files Coverage Δ
...pay/sofa/common/thread/SofaThreadPoolExecutor.java 98.92% <100.00%> (+0.06%) ⬆️
...ofa/common/thread/SofaThreadPoolTaskScheduler.java 77.27% <100.00%> (+1.66%) ⬆️
...common/thread/SofaScheduledThreadPoolExecutor.java 97.97% <94.73%> (-0.82%) ⬇️
...sofa/common/thread/SofaThreadPoolTaskExecutor.java 79.62% <75.00%> (-0.38%) ⬇️
...y/sofa/common/thread/SofaTracerCommandFactory.java 62.50% <62.50%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 7841cae into sofastack:master Oct 10, 2023
HzjNeverStop added a commit to HzjNeverStop/sofa-common-tools that referenced this pull request Oct 23, 2023
HzjNeverStop added a commit that referenced this pull request Oct 31, 2023
* Support auto transform SOFATracer Span in SOFA ThreadPool (#190)

* update 1.3.13

---------

Co-authored-by: “HzjNeverStop” <“441627022@qq.com”>
HzjNeverStop added a commit that referenced this pull request Nov 7, 2023
* Support auto transform SOFATracer Span in SOFA ThreadPool (#190)

* update 1.3.13

* Fix init loggerSpace in concurrency

* fix pmd

* fix pmd

---------

Co-authored-by: “HzjNeverStop” <“441627022@qq.com”>
@OrezzerO
Copy link
Contributor

I think its too heavy to provide SofaXXXThreadpools. Maybe a wrapper SofaThreadpoolWarpper or SofaThreadFactory will be more reasonable.

BTW, byte code enhancement is suitable in such situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0