8000 Support logback 1.4.9, fix logback compatibility by HzjNeverStop · Pull Request #188 · sofastack/sofa-common-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support logback 1.4.9, fix logback compatibility #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2023
Merged

Support logback 1.4.9, fix logback compatibility #188

merged 4 commits into from
Aug 11, 2023

Conversation

HzjNeverStop
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/M labels Aug 10, 2023
@codecov
Copy link
codecov bot commented Aug 10, 2023

Codecov Report

Merging #188 (c17e018) into master (3250b66) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 67.71%.

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     34.56%   34.58%   +0.01%     
+ Complexity      678      668      -10     
============================================
  Files            77       74       -3     
  Lines          5722     5673      -49     
  Branches       1101     1090      -11     
============================================
- Hits           1978     1962      -16     
+ Misses         3491     3464      -27     
+ Partials        253      247       -6
Files Changed Coverage Δ
...main/java/com/alipay/sofa/common/log/LogSpace.java 80.00% <ø> (ø)
...va/com/alipay/sofa/common/log/env/LogEnvUtils.java 62.92% <0.00%> (+0.69%) ⬆️
...common/log/factory/AbstractLoggerSpaceFactory.java 42.85% <ø> (ø)
...log/factory/AbstractLoggerSpaceFactoryBuilder.java 83.65% <ø> (-0.16%) ⬇️
.../log/factory/LoggerSpaceFactory4Log4j2Builder.java 71.42% <ø> (-6.35%) ⬇️
...log/factory/LoggerSpaceFactory4LogbackBuilder.java 100.00% <ø> (ø)
.../com/alipay/sofa/common/log/proxy/LoggerProxy.java 8.54% <ø> (ø)
...sofa/common/log/proxy/TemporaryILoggerFactory.java 100.00% <ø> (ø)
.../common/log/proxy/TemporaryILoggerFactoryPool.java 36.11% <0.00%> (-1.04%) ⬇️
...pay/sofa/common/thread/SofaThreadPoolExecutor.java 98.86% <ø> (+10.08%) ⬆️
... and 17 more

... and 5 files with indirect coverage changes

crazysaltfish
crazysaltfish approved these changes Aug 10, 2023
View reviewed changes
Copy link
@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit ec43d9b into sofastack:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazysaltfish crazysaltfish crazysaltfish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HzjNeverStop @crazysaltfish
0