8000 add sofarpc endpoint by HzjNeverStop · Pull Request #1169 · sofastack/sofa-boot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add sofarpc endpoint #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2023
Merged

add sofarpc endpoint #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bdc3ea6
add sofarpc endpoint
Apr 24, 2023
83e2e0e
Merge branch 'v4.0.0' into upcsupport_rpc_endpoin
Apr 24, 2023
bc8c7e0
format
Apr 24, 2023
9e7fdf6
fix actuator ut
Apr 24, 2023
9b85065
fix actuator ut
Apr 24, 2023
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...in/java/com/alipay/sofa/boot/actuator/autoconfigure/rpc/RpcActuatorAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import com.alipay.sofa.boot.actuator.health.ReadinessEndpoint;
import com.alipay.sofa.boot.actuator.rpc.RpcAfterHealthCheckCallback;
import com.alipay.sofa.boot.actuator.rpc.SofaRpcEndPoint;
import com.alipay.sofa.boot.autoconfigure.rpc.SofaRpcAutoConfiguration;
import com.alipay.sofa.rpc.boot.context.RpcStartApplicationListener;
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
Expand All @@ -37,12 +38,19 @@
@AutoConfiguration(after = SofaRpcAutoConfiguration.class)
@ConditionalOnClass(RpcStartApplicationListener.class)
@ConditionalOnBean(RpcStartApplicationListener.class)
@ConditionalOnAvailableEndpoint(endpoint = ReadinessEndpoint.class)
public class RpcActuatorAutoConfiguration {

@Bean
@ConditionalOnMissingBean
@ConditionalOnAvailableEndpoint(endpoint = ReadinessEndpoint.class)
public RpcAfterHealthCheckCallback rpcAfterHealthCheckCallback(RpcStartApplicationListener rpcStartApplicationListener) {
return new RpcAfterHealthCheckCallback(rpcStartApplicationListener);
}

@Bean
@ConditionalOnMissingBean
@ConditionalOnAvailableEndpoint(endpoint = SofaRpcEndPoint.class)
public SofaRpcEndPoint sofaRpcEndPoint() {
return new SofaRpcEndPoint();
}
}
15 changes: 10 additions & 5 deletions ...va/com/alipay/sofa/boot/actuator/autoconfigure/rpc/RpcActuatorAutoConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.alipay.sofa.boot.actuator.autoconfigure.rpc;

import com.alipay.sofa.boot.actuator.rpc.RpcAfterHealthCheckCallback;
import com.alipay.sofa.boot.actuator.rpc.SofaRpcEndPoint;
import com.alipay.sofa.rpc.boot.context.RpcStartApplicationListener;
import org.junit.jupiter.api.Test;
import org.springframework.boot.autoconfigure.AutoConfigurations;
Expand All @@ -38,14 +39,15 @@ public class RpcActuatorAutoConfigurationTests {
AutoConfigurations
.of(RpcActuatorAutoConfiguration.class))
.withPropertyValues(
"management.endpoints.web.exposure.include=readiness");
"management.endpoints.web.exposure.include=readiness,rpc");

@Test
void runShouldHaveRpcActuatorBeans() {
this.contextRunner
.withBean(RpcStartApplicationListener.class)
.run((context) -> assertThat(context)
.hasSingleBean(RpcAfterHealthCheckCallback.class));
.hasSingleBean(RpcAfterHealthCheckCallback.class)
.hasSingleBean(SofaRpcEndPoint.class));
}

@Test
Expand All @@ -54,7 +56,8 @@ void runWhenNotExposedShouldNotHaveReadinessBeans() {
.withBean(RpcStartApplicationListener.class)
.withPropertyValues("management.endpoints.web.exposure.include=info")
.run((context) -> assertThat(context)
.doesNotHaveBean(RpcAfterHealthCheckCallback.class));
.doesNotHaveBean(RpcAfterHealthCheckCallback.class)
.doesNotHaveBean(SofaRpcEndPoint.class));
}

@Test
Expand All @@ -63,13 +66,15 @@ void runWhenRpcClassNotExist() {
.withBean(RpcStartApplicationListener.class)
.withClassLoader(new FilteredClassLoader(RpcStartApplicationListener.class))
.run((context) -> assertThat(context)
.doesNotHaveBean(RpcAfterHealthCheckCallback.class));
.doesNotHaveBean(RpcAfterHealthCheckCallback.class)
.doesNotHaveBean(SofaRpcEndPoint.class));
}

@Test
void runWhenRpcBeanNotExist() {
this.contextRunner
.run((context) -> assertThat(context)
.doesNotHaveBean(RpcAfterHealthCheckCallback.class));
.doesNotHaveBean(RpcAfterHealthCheckCallback.class)
.doesNotHaveBean(SofaRpcEndPoint.class));
}
}
Loading
0