8000 Initial Signals Docs by Jack-Keene · Pull Request #1197 · snowplow/documentation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initial Signals Docs #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10000
Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Initial Signals Docs #1197

wants to merge 29 commits into from

Conversation

Jack-Keene
Copy link
Contributor

No description provided.

@Jack-Keene Jack-Keene marked this pull request as ready for review April 7, 2025 16:34
Copy link
netlify bot commented Apr 7, 2025

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit adfc74c
🔍 Latest deploy log https://app.netlify.com/projects/snowplow-docs/deploys/685e5a2507d2a40008305a61
😎 Deploy Preview https://deploy-preview-1197--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mscwilson mscwilson added the do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release) label Apr 7, 2025
| `events` | List of Snowplow Events that the Attribute is calculated on | List of `Event` type |
| `aggregation` | The aggregation type of the Attribute | One of: `counter`, `sum`, `min`, `max`, `mean`, `first`, `last`, `unique_list` |
| `property_syntax` | The syntax used to reference the property. | One of: `snowflake`, `blobl` |
| `property` | The property of the event or entity you wish to use in the aggregation | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need a bit more documentation on this as there are complexities about the syntax and naming that should be used here.

We decided that we'll use Snowflake syntax for accessing nested properties within events and entities. Also the columns names are the same as in the atomic events table. There was a bit more detail in this doc.

One can also access other properties in the atomic events table like app_id and more. It'd be great to provide some examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it deserves a separate paragraph/section as users will definitely need to figure out how to do that.

Copy link
Contributor
@johnmicahreid johnmicahreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilias1111 left some comments re the batch tutorial

@@ -0,0 +1,5 @@
{
"title": "Snowplow Signals CLI Tutorial",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilias1111 can we rename this to Create Batch Attributes using Snowplow Signals?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create Batch Attributes using Snowplow Signals But isnt what we are doin, we are creating dbt projects ( batch engine projects ) based on already generated attributes :/ What should we say?

D7E7
Before starting, ensure you have:

- Python 3.11+ installed
- Snowplow Signals SDK installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show them how to install this - have a pip install command or something.

Also it's not totally obvious to me that installing a Python package means it can be used as a CLI tool, maybe just clarify that piece.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is skipped for now, in the sense that the cli is not live in pypi thus i cannot test the command and there is no point to saying it. Will add it when we are live with the sdk

- API URL
- API Key
- API Key ID
- Organization ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell them how to find all these bits of information - you can copy from the Quickstart guide.

--api-key "YOUR_API_KEY" \
--api-key-id "YOUR_API_KEY_ID" \
--org-id "YOUR_ORG_ID" \
--repo-path "./my_snowplow_repo" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should show a step to create the repo earlier on (mkdir...)


## Choosing Between Options

- Use **Option 1** when you want to set up projects for all your batch views at once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already forgotten what Option 1 and 2 were here, could you just use their descriptive names?

agnessnowplow and others added 2 commits April 25, 2025 16:37
* Add missing batch content

* Updates

* Updates on the installation

* John changes

---------

Co-authored-by: Ilias Xenogiannis <ilias1111@users.noreply.github.com>
* Rename signals to sp_signals

* Rename cli tutorial

* Remove cli details from batch engine

* Add view prerequisite to cli tutorial

* Add online offline to view def

* Clarify onlne offline matrix

* Update docs/signals/views_services/index.md
@johnmicahreid johnmicahreid requested a review from mscwilson May 21, 2025 10:45
@mscwilson
Copy link
Collaborator

Can someone check this PR against Vale please, haven't finished reviewing yet but seen a few formatting problems

Copy link
Collaborator
@mscwilson mscwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new Signals terms to the Glossary please

I haven't reviewed the Tutorial part since the main docs are more urgent

$ pip install snowplow-signals
```

To connect to your Signals deployment, you will need 4 values.
10000 Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this 3 things

@johnmicahreid johnmicahreid requested review from miike and jethron May 22, 2025 09:10
@jethron jethron force-pushed the add-signals-docs branch from eed7d0d to 5f491c3 Compare June 10, 2025 07:49
ilias1111 and others added 9 commits June 11, 2025 15:35
* Move stuff around

* Add overview to intro page

* Add links

* Move paragraph

* Update following review
PR #1293
* update architeture diagram
* add custom entity docs
* add Stream limitations note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0