Merge multiprocess and lwaftr branches #1148
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove useless pcap files, clarify docs and code.
Hard word wrap at 80 chars for filter perf doc
Sketch out Igalia's testing strategy
Changelog v3.1.5
Minor improvements to snabb config listen
Print out worker info in 'snabb ps'
Add basic error reporting to snabb-softwire-v1
- Get rid of `screen` command. - Connect to VM via telnet instead of ssh. - Change syntax to "verb command". - Remove "lwaftr" command. - Enable extra tap network interface to have external internet access from the guest.
Also run selftest in dasl files
- program/lwaftr/Makefile: Clean up .o files. - program/snabbvmx/Makefile: Clean up .o files.
Refactor lwaftrctl
Clean lwaftr object files
Tables of callback functions are now cached as instance variables
rather than being created with {...} on every call. These allocations
were not being sunk and so this eliminates heap allocation & GC.
(cherry picked from commit 76782f5)
* src/Makefile (snabb): Correctly add YANGOBJs.
* src/program/wall/tests/selftest.sh (SKIPPED_CODE): Skip if ndpi isn't available.
* src/program/wall/tests/selftest.sh (SKIPPED_CODE): Reverse the sense of the check.
Merge upstream v2017.04 into lwaftr
The snabbvmx selftest currently passes only when run on a system with a 3.x kernel on the host. We will fix this but in the interests of getting the lwaftr in a mergeable state, temporarily disabling this test by renaming it.
…mx-test Temporarily disable snabbvmx selftest
See snabbco#1145 for more discussion.
…intel_mp Disable bus-mastering cleanup for intel_mp
…-multiproc-lwaftr
…ultiproc-lwaftr
|
I don't quite understand the snabbdoc build error; do you, @lukego? I would think we can merge this to |
|
Sorry about the wait. Hopefully fixed in 56a5acf. |
lukego
added a commit
that referenced
this pull request
Jun 2, 2017
|
Yep that did it. Merged onto |
takikawa
added a commit
to takikawa/snabb
that referenced
this pull request
Jul 12, 2018
Share queue stats among all apps on a NIC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integration branch is based on
nextand first merges multiprocess support (#1021) and then the latest lwAFTR (#1133).The lwAFTR branch has already merged the multiprocess branch several times during development and so many commits are common to both branches. The reason that I merge both onto this integration branch is to make sure no commits are left behind and to detect any conflicts before landing on
next. Git did not detect any conflicts so if the CI tests pass we are golden.For anybody who wants to see how the new multiprocess support works: hop over to #1021 to see the short README for the API and shortish diff for the code. Don't be distracted by all of the discussion threads on the #1021 PR because that is mostly preliminary chatter while we thrashed out a working design. The API and implementation are both quite small and straightforward.