8000 [BUG] Incorrect "Normal exposure" at Dynamic Layer Height dialog · Issue #274 · sn4k3/UVtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] Incorrect "Normal exposure" at Dynamic Layer Height dialog #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sat360 opened this issue Aug 27, 2021 · 3 comments
Closed

[BUG] Incorrect "Normal exposure" at Dynamic Layer Height dialog #274

Sat360 opened this issue Aug 27, 2021 · 3 comments
Assignees
@sn4k3
Labels
bug Something isn't working

Comments

@Sat360
Copy link
Sat360 commented Aug 27, 2021

System

  • OS: [e.g. Windows 10 x64 v20H2]
  • Slicer:
  • Printer:

Describe the bug

When I choose "Exposure set type = Multiplier" at Dynamic Layer Height dialog, I got same start values for bottom exposure time and normal exposure time.

Screenshots

изображение

Additional context

Error in "OperationDynamicLayerHeight.cs" file, line 348.
Now:
exposure = (decimal)SlicerFile.BottomExposureTime + (decimal)SlicerFile.ExposureTime * count * layerHeight * _exposureStep;
Must be:
exposure = (decimal)SlicerFile.ExposureTime + (decimal)SlicerFile.ExposureTime * count * layerHeight * _exposureStep;

I'm sorry, I don't know how to use github :)
@Sat360
Copy link
Author
Sat360 commented Aug 27, 2021

Ouch. Same error on string 452, may be on some other strings...

@sn4k3
Copy link
Owner
sn4k3 commented Aug 27, 2021 •
edited
Loading

Ok you are a bug hunter 😄 I will fix that too.
Maybe i should allow to set the base exposure on the dialog too...

@sn4k3 sn4k3 added the bug Something isn't working label Aug 27, 2021
sn4k3 added a commit that referenced this issue Aug 28, 2021
@sn4k3
v2.20.3
e7d474b 
- **Tool - Dynamic Layer Height:**
   - (Add) Option to strip anti-aliasing: Use this option if you get flashy layers or if you want to enhancement the results
   - (Add) Option to reconstruct anti-aliasing: Use this option with "Strip anti-aliasing" to reconstruct the layer anti-aliasing via an gaussian blur
   - (Add) Maximum wide difference: The maximum number of pixels wide difference to be able to stack layers, where one pixel difference is a whole perimeter of the object to be eroded.
      0 = Stack only equal layers
      n = Stack equal layers or with a n perimeter of difference between the sum of the stack (#274)
   - (Add) Allow to change the base exposure times for the auto generation (#274)
   - (Add) Option to switch between: "Set the same base time for all bottoms" or "Calculate and iterate bottom exposures"
   - (Add) Button to: Copy automatic table data into manual table
   - (Improvement) Auto fill all layer height exposures times on manual entry
   - (Fix) When "Exposure set type = Multiplier" bottom exposure is being used for normal exposure (#274)
   - (Fix) Do not sum equal layers on the stack
- (Fix) Recalculate the material milliliters per layer when replacing a layer collection (#273)
@sn4k3
Copy link
Owner
sn4k3 commented Aug 28, 2021

Fixed

@sn4k3 sn4k3 closed this as completed Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sn4k3 sn4k3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sn4k3 @Sat360
0