fix: drop join handle in spawn utils #337
Conversation
There was a problem hiding this comment.
While this was the original intention, it's actually more problematic to drop the join handle from these utilities and limits their usefulness. The JoinHandle serves a strong purpose in tracking the full exit of the future owning any spawned actor, and it should really be caller dependent if it's dropped.
It's a minor ergonomic overhead to drop it as the caller, either with await.0 or (actor, _) = ...::spawn(). Therefore I'm going to say no to these changes. Feel free to update the comments however, they are indeed out of date and incorrect.
|
I see, but isn't the idea about caller decision still holds? I mean if they decide not to use the handle and stop and wait later, then they use this utility method. Otherwise, they use original method. But then there is probably another problem with this method that it will include not just one, but two shortcuts: dropping handle and default for actor implementors. |
|
Yeah I'd prefer to keep this to one implied change. It's helpful for defaults but losing the join handle has a lot of consequences downstream |
This PR refactors
ractor::spawnandractor::spawn_namedto drop the internalJoinHandlebefore returning the function’s output. Based on the current documentation and observed usage patterns, this change simplifies the API by removing unnecessary exposure of theJoinHandleto the caller.Note: this is a breaking change.