slack-19.0: pre-backport v23 vtorc PR vitessio/vitess#17985
#635
+6,176
−3,130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
vtorc: add support for dynamic enable/disable of ERS by keyspace/shardslack-19.0: backport v22 vtorc PR vitessio/vitess#17985
slack-19.0: backport v22 vtorc PR vitessio/vitess#17985slack-19.0: pre-backport v23 vtorc PR vitessio/vitess#17985
ejortegau
reviewed
Apr 16, 2025
|
|
||
| defer unlock(&err) | ||
|
|
||
| if req.Shard != "" && req.Shard != "-" { |
There was a problem hiding this comment.
I have seen single shard keyspaces referred to as shard 0. Should that be included here?
There was a problem hiding this comment.
@ejortegau technically 0 is a single shard in the middle of the keyspace. And - is actually referring to the entire shard range of the keyspace
So, no I believe this logic is correct as-is. Considering 0 to be a whole keyspace has consequences on splits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-backport upstream v23 PR vitessio#17985 in order to provide some test results to upstream
Related Issue(s)
vitessio#17985
Checklist
Deployment Notes