feat: impl "Sheets" like behavior #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
toshi0383
commented
Feb 22, 2022
| @@ -345,7 +345,7 @@ private extension PanModalPresentationController { | |||
| in the presentation animator instead of here | |||
| */ | |||
| containerView.addSubview(presentedView) | |||
| containerView.addGestureRecognizer(panGestureRecognizer) | |||
| presentedView.addGestureRecognizer(panGestureRecognizer) | |||
There was a problem hiding this comment.
Required but breaking change here.
IMO this makes more sense though, because the background area shouldn't be pull-to-dismissable.
toshi0383
commented
Feb 22, 2022
| @@ -54,7 +75,9 @@ class SampleViewController: UITableViewController { | |||
| return | |||
| } | |||
| dismiss(animated: true, completion: nil) | |||
| presentPanModal(rowType.presentable.rowVC) | |||
| let vc = rowType.presentable.rowVC | |||
| hitTestView.hitTestDelegateView = vc.view | |||
There was a problem hiding this comment.
containerView have to be isUserInteractionEnabled: false to enable user interaction in presentingVC, so this did the trick to also enable it in presentedVC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes: #168
169.mp4
Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.