8000 [gui] Renaming a method to something that would match a keyword breaks the intellisense functionality for that method · Issue #1557 · skylot/jadx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[gui] Renaming a method to something that would match a keyword breaks the intellisense functionality for that method #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dragas opened this issue Jun 24, 2022 · 2 comments
Closed

[gui] Renaming a method to something that would match a keyword breaks the intellisense functionality for that method #1557

Dragas opened this issue Jun 24, 2022 · 2 comments

Comments

@Dragas
Copy link
Dragas commented Jun 24, 2022

The title is kind of verbose, but it summarizes the issue as best as possible. I run preference settings where I would attempt to deobfuscate anything that's less then 3 characters long (the default), so that I would afterwards rename the methods, variables, and etc. to proper names after figuring out what they're doing. In poor judgement, I had renamed a single method to assert, which corresponds to a keyword in java.
image
As a result, jad-gui now considers the method to be a keyword, and I am no longer able to perform any intellisense operations (such as find usages, rename, go to declaration) on that method, and any callers of that method.
image
In addition, the tool prevents reverting this action.
@Dragas
Copy link
Author
Dragas commented Jun 24, 2022

Looking at the logs, they do not seem to provide anything besides the bad byte error.
https://pastebin.com/M8W6DbGN

skylot added a commit that referenced this issue Jun 29, 2022
@skylot
fix(gui): check user renames (#1557)
2f2fbea
@skylot
Copy link
Owner
skylot commented Jun 29, 2022

@Dragas I add a check before rename to forbid not valid java identifiers.

@skylot skylot closed this as completed Jun 29, 2022
@anantshri anantshri mentioned this issue Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skylot @Dragas
0