8000 [BUG] fix `RotationForest` for a custom `base_estimator` by fkiraly · Pull Request #8270 · sktime/sktime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] fix RotationForest for a custom base_estimator #8270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BUG] fix RotationForest for a custom base_estimator #8270

wants to merge 2 commits into from
+13 −4

Conversation

fkiraly
Copy link
Collaborator
@fkiraly fkiraly commented May 20, 2025 •
edited
Loading

Fixes #8265 - the reason was that base_estimator was not written to self._base_estimator when a non-standard one was provided.

Adds the failure case to the test.

@fkiraly fkiraly added module:classification classification module: time series classification bugfix Fixes a known bug or removes unintended behavior labels May 20, 2025
@fkiraly fkiraly mentioned this pull request May 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@felipeangelimvieira felipeangelimvieira Awaiting requested review from felipeangelimvieira felipeangelimvieira is a code owner

@fnhirwa fnhirwa Awaiting requested review from fnhirwa fnhirwa is a code owner

@geetu040 geetu040 Awaiting requested review from geetu040 geetu040 is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior module:classification classification module: time series classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] AttributeError in RotationForest when using base_estimator parameter
1 participant
@fkiraly
0