8000 [FRE-1915] Fix low info text line height by ericHgorski · Pull Request #1363 · skip-mev/skip-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FRE-1915] Fix low info text line height #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericHgorski
Copy link
Collaborator

Summary

  • bump widget with changeset
  • apply consistent line-height to the subtext on the incomplete price data warning page

Testing


https://chatgpt.com/codex/tasks/task_b_6849bc6e3d1c83299d129fd1f9d1bbb0

Copy link
vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 5:45pm

Copy link
changeset-bot bot commented Jun 11, 2025

🦋 Changeset detected

Latest commit: 4ccf15b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skip-go/widget Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
lumberjack-bot bot commented Jun 11, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@ericHgorski ericHgorski changed the title Fix low info text line height [FRE-1915] Fix low info text line height Jun 11, 2025
Copy link
linear bot commented Jun 11, 2025

@@ -90,3 +92,7 @@ export const WarningPageLowInfo = ({
</>
);
};

const StyledDescriptionContent = styled.div`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we apply this to all warning error page content

Copy link
Member
@codingki codingki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can add this to every error warning page content

@codingki codingki merged commit 72b468f into staging Jun 11, 2025
6 checks passed
@codingki codingki deleted the eg/increase-line-height-on-incomplete-price-data-page branch June 11, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0