add storing extra chainIdsPerWallet in localStorage and auto-clearing it and retrying if there's an error when attempting to connect wallet #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it and retrying if there's an error when attempting to connect wallet
🦋 Changeset detectedLatest commit: b7e24dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s not include sourceAsset.chainId
toddkao
commented
Jun 3, 2025
Comment on lines
161
to
177
|
|
||
| if (extraCosmosChainIdsToConnectPerWallet?.[wallet]?.length > 0) { | ||
| clearCosmosChainIdsToConnectForWalletType(wallet); | ||
|
|
||
| const retryChainIds = filterValidChainIds([...getInitialChainIds(wallet)], chains); | ||
|
|
||
| const response = await connect({ | ||
| chainId: connectToInitialChainId | ||
| ? retryChainIds | ||
| : [...retryChainIds, chainIdToConnect], | ||
| walletType: wallet, | ||
| autoReconnect: false, | ||
| }); | ||
| const address = | ||
| chainIdToConnect && response?.accounts[chainIdToConnect].bech32Address; | ||
| return { address }; | ||
| } |
There was a problem hiding this comment.
this clears the extra chainIds for a given wallet if there's an error and some extraChainIds exist, so that if that chainId is removed from your wallet it won't show an error to the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.