8000 add onSourceAssetUpdated/onDestinationAssetUpdated and setAsset function by toddkao · Pull Request #1307 · skip-mev/skip-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add onSourceAssetUpdated/onDestinationAssetUpdated and setAsset function #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jun 3, 2025
Merged

add onSourceAssetUpdated/onDestinationAssetUpdated and setAsset function #1307

merged 31 commits into from
Jun 3, 2025

Conversation

toddkao
Copy link
Collaborator
@toddkao toddkao commented Jun 3, 2025

No description provided.

@linear Linear
Copy link
linear bot commented Jun 3, 2025

FRE-1872 Add `onSourceAssetChange` and `onDestinationAssetChange` callbacks to Skip Widget and expose `setDestination` and `setSource`

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0abcd58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skip-go/widget Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link
vercel bot commented Jun 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 9:40pm

@toddkao toddkao changed the base branch from staging to FRE-1863 June 3, 2025 20:50
github-actions bot and others added 5 commits June 3, 2025 16:50
@github-actions @toddkao
sync: main to staging (#1303)
1b5b6a3 
Co-authored-by: Todd Kao <todd.kakao@gmail.com>
Co-authored-by: Todd Kao <toddkao@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
10000 @toddkao
add onSourceAssetUpdated and setAsset function
6b5a64f
@toddkao
remove unused import
0fe8bee
@toddkao
fix setting amount
847d5fa
@toddkao
add onSourceAssetUpdated and onDestinationAssetUpdated
bbb8bf1
@toddkao toddkao changed the title add onSourceAssetUpdated and setAsset function add onSourceAssetUpdated/onDestinationAssetUpdated and setAsset function Jun 3, 2025
ericHgorski
ericHgorski approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator
@ericHgorski ericHgorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from FRE-1863 to staging June 3, 2025 21:07
@toddkao toddkao merged commit 871bec1 into staging Jun 3, 2025
5 of 6 checks passed
@toddkao toddkao deleted the FRE-1872 branch June 3, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericHgorski ericHgorski ericHgorski approved these changes

@codingki codingki Awaiting requested review from codingki codingki is a code owner

@NotJeremyLiu NotJeremyLiu Awaiting requested review from NotJeremyLiu NotJeremyLiu is a code owner

@daps94 daps94 Awaiting requested review from daps94 daps94 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddkao @ericHgorski
0