Merge pull request #22 from skadewdl3/plugins-test #70
Annotations
10 warnings
|
you seem to be trying to use `&Box<T>`. Consider using just `&T`:
flint-macros/src/codegen/conditional.rs#L32
warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
--> flint-macros/src/codegen/conditional.rs:32:15
|
32 | if_child: &Box<Widget>,
| ^^^^^^^^^^^^ help: try: `&Widget`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
= note: `#[warn(clippy::borrowed_box)]` on by default
|
|
returning the result of a `let` binding from a block:
flint-macros/src/codegen/conditional.rs#L67
warning: returning the result of a `let` binding from a block
--> flint-macros/src/codegen/conditional.rs:67:17
|
66 | let else_child_widget = generate_widget_code(else_child, &new_options);
| ----------------------------------------------------------------------- unnecessary `let` binding
67 | else_child_widget
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
66 ~
67 ~ generate_widget_code(else_child, &new_options)
|
|
|
you seem to be trying to use `&Box<T>`. Consider using just `&T`:
flint-macros/src/codegen/conditional.rs#L32
warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
--> flint-macros/src/codegen/conditional.rs:32:15
|
32 | if_child: &Box<Widget>,
| ^^^^^^^^^^^^ help: try: `&Widget`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
= note: `#[warn(clippy::borrowed_box)]` on by default
|
|
returning the result of a `let` binding from a block:
flint-macros/src/codegen/conditional.rs#L67
warning: returning the result of a `let` binding from a block
--> flint-macros/src/codegen/conditional.rs:67:17
|
66 | let else_child_widget = generate_widget_code(else_child, &new_options);
| ----------------------------------------------------------------------- unnecessary `let` binding
67 | else_child_widget
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
66 ~
67 ~ generate_widget_code(else_child, &new_options)
|
|
|
you seem to be trying to use `&Box<T>`. Consider using just `&T`:
flint-macros/src/codegen/iter_layout.rs#L35
warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
--> flint-macros/src/codegen/iter_layout.rs:35:12
|
35 | child: &Box<Widget>,
| ^^^^^^^^^^^^ help: try: `&Widget`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
|
|
unneeded `return` statement:
flint-macros/src/codegen/iter_layout.rs#L166
warning: unneeded `return` statement
--> flint-macros/src/codegen/iter_layout.rs:166:13
|
166 | / return quote! {{
167 | | #layout_code
168 | | #wrapper_code
169 | | #render_statements
170 | | }};
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
166 ~ quote! {{
167 + #layout_code
168 + #wrapper_code
169 + #render_statements
170 ~ }}
|
|
|
you seem to be trying to use `&Box<T>`. Consider using just `&T`:
flint-macros/src/codegen/iter_layout.rs#L35
warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
--> flint-macros/src/codegen/iter_layout.rs:35:12
|
35 | child: &Box<Widget>,
| ^^^^^^^^^^^^ help: try: `&Widget`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
|
|
unneeded `return` statement:
flint-macros/src/codegen/iter_layout.rs#L166
warning: unneeded `return` statement
--> flint-macros/src/codegen/iter_layout.rs:166:13
|
166 | / return quote! {{
167 | | #layout_code
168 | | #wrapper_code
169 | | #render_statements
170 | | }};
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
166 ~ quote! {{
167 + #layout_code
168 + #wrapper_code
169 + #render_statements
170 ~ }}
|
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
flint-macros/src/codegen/layout.rs#L45
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> flint-macros/src/codegen/layout.rs:45:15
|
45 | children: &Vec<Widget>,
| ^^^^^^^^^^^^ help: change this to: `&[Widget]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
flint-macros/src/codegen/layout.rs#L45
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> flint-macros/src/codegen/layout.rs:45:15
|
45 | children: &Vec<Widget>,
| ^^^^^^^^^^^^ help: change this to: `&[Widget]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|