10000 Use `emojilib` to enhance results by stroncium · Pull Request #39 · sindresorhus/emoj · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use emojilib to enhance results #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 5, 2020
Merged

Use emojilib to enhance results #39

merged 7 commits into from
Mar 5, 2020

Conversation

stroncium
Copy link
@stroncium stroncium commented Mar 24, 2019 •
edited by sindresorhus
Loading

Adds emojilib results to what we get from getdango.

Filtering of emojilib is done with simple heuristic(ignore some characters, do exact matches on long searches, substring matches on short searches).

Also, allowed using only emojilib if getdango API is not available for some reason.

Fixes #30
Closes #40

@stroncium stroncium changed the title solves #30 Use emojilib to enhance results Jun 28, 2019
@mesqueeb mesqueeb mentioned this pull request Aug 13, 2019
Closed
sindresorhus
sindresorhus requested changes Feb 22, 2020
View reviewed changes
@sindresorhus
Copy link
Owner

This generally looks good :)

@sindresorhus
Copy link
Owner

There's a check in ui.js that checks if dango is offline. I don't think we need that anymore since we have this.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@stroncium
Copy link
Author

@sindresorhus I think I cleaned up ui.js though I have no idea what it is used for/from so didn't test.

sindresorhus
sindresorhus reviewed Mar 3, 2020
View reviewed changes
@sindresorhus
Copy link
Owner

I tried turning off my wifi, and it doesn't work:

› horse



GotError: getaddrinfo ENOTFOUND emoji.getdango.com emoji.getdango.com:80
    at onError (/Users/sindresorhus/dev/oss/emoj/node_modules/got/dist/source/request-as-event-emitter.js:140:29)
    at handleRequest (/Users/sindresorhus/dev/oss/emoj/node_modules/got/dist/source/request-as-event-emitter.js:173:17)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:56:26)

@stroncium
Copy link
Author

@sindresorhus Ok, figured it out now, didn't notice there was interactive mode. Getdango errors were thrown up in case local db got no results, ignoring them completely now.

@sindresorhus sindresorhus merged commit 7de37c4 into sindresorhus:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance 3rd party result with local information
2 participants
@stroncium @sindresorhus
0