8000 Implemented the Quick Action feature from issue #180 by mmulet · Pull Request #330 · sindresorhus/Gifski · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implemented the Quick Action feature from issue #180 #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implemented the Quick Action feature from issue #180 #330

wants to merge 3 commits into from

Conversation

mmulet
Copy link
Contributor
@mmulet mmulet commented Mar 24, 2025 •
edited by issuehunt-oss bot
Loading

Hi!

I implemented the Quick Action feature from issue #180
This time I have 2 videos for you!
This one shows how you can use the quick action:

  1. Just select the video, select Quick action -> Quick Convert to GIF with Gifski
  2. Then it quickly converts the GIF!
  3. The gif is saved in to Downloads folder (the easiest place to save from an App Sandbox perspective), and the Quick Action opens Finder to the file after it creates it.
QuickAction_Demo1.mov

The second video shows how you can change the sensible defaults for quick conversion.
Just open settings from the menu bar or Cmd+, and then edit the settings using
the same UI as you use in the normal app.
https://github.com/user-attachments/assets/e84b0ba4-2206-48d1-8951-5fe5955e2ba1

I believe this should be exactly what you wanted!

Once again I will submit this to issueHunt for the ongoing bounty, but any extra tips (you
can use GitHub Sponsor page) would be very welcome!

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

Implemented the Quick Action feature from issue sindresorhus#180
02eecda 
This adds the Quick Convert to GIF with Gifski
quick action in finder, and the settings view which
let's you provide the settings for used when quick
converting.
@mmulet mmulet mentioned this pull request Mar 25, 2025
Open
@sindresorhus
Copy link
Owner

I've been thinking more about this, and I'm not sure it actually makes sense to have a single set of settings that always apply. I know I originally suggested that in the issue, but I hadn't fully thought it through.

The optimal GIF settings really depend on the kind of video you're converting, and there can be many different use-cases. Showing a small settings window each time could help, but then users might also expect a preview, and at that point, we’re basically back at the main app UI.

Now that we support Shortcuts, I’m wondering if a better approach is to let users create their own shortcuts with their preferred settings. These can also show up in the Quick Actions menu, which keeps things both flexible and efficient.

Thoughts?

@mmulet
Copy link
Contributor Author
mmulet commented Jun 25, 2025

I've been thinking more about this, and I'm not sure it actually makes sense to have a single set of settings that always apply. I know I originally suggested that in the issue, but I hadn't fully thought it through.

The optimal GIF settings really depend on the kind of video you're converting, and there can be many different use-cases. Showing a small settings window each time could help, but then users might also expect a preview, and at that point, we’re basically back at the main app UI.

Now that we support Shortcuts, I’m wondering if a better approach is to let users create their own shortcuts with their preferred settings. These can also show up in the Quick Actions menu, which keeps things both flexible and efficient.

Thoughts?

Yeah, I like this new idea better too. The shortcuts app is basically a microcosm of the settings anyways.
I gave it a try and it works well:

Screen.Recording.2025-06-25.at.1.20.15.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmulet @sindresorhus
0