Add hyprpaper support #99
Conversation
| const hyprpaper = childProcess.spawn('script', ['--quiet', '--command', 'hyprpaper', '/dev/null']); | ||
| hyprpaper.stdout.on('data', data => { | ||
| if (data.toString().includes('[ERR]') || data.toString().includes('error')) { | ||
| throw new Error(data.toString()); |
There was a problem hiding this comment.
You cannot throw from here. Use reject.
| // Query output looks like: | ||
| // eDP-1 = /path/to/image | ||
| // HDMI-A-1 = /path/to/image | ||
| return query.split(' ').at(-1).replace(/(\r\n|\n|\r)/gm, ''); |
There was a problem hiding this comment.
Not clear what the replace call is supposed to do. But I would split on newlines first and then on =.
There was a problem hiding this comment.
I used .replace() to remove newlines. If you split on newlines then on '=' in result there will be extra space like here: ' /path/to/image' instead of '/path/to/image'.
| export async function set(imagePath) { | ||
| await initialize(); | ||
| const commandArray = []; | ||
| const {stdout: monitors} = await exec('hyprctl monitors | grep "Monitor" | awk \'{ print $2 }\''); |
There was a problem hiding this comment.
Use execFile. Transformations should be done in JS.
There was a problem hiding this comment.
Here too, add a comment what the output of hyprctl monitors looks like.
| for (const monitor of monitors.split('\n').slice(0, -1)) { | ||
| commandArray.push(execFile('hyprctl', ['hyprpaper', 'wallpaper', `${monitor},${imagePath}`])); | ||
| } |
There was a problem hiding this comment.
Use .map instead of a loop.
| return new Promise((resolve, reject) => { | ||
| const hyprpaper = childProcess.spawn('script', ['--quiet', '--command', 'hyprpaper', '/dev/null']); | ||
| hyprpaper.stdout.on('data', data => { | ||
| if (data.toString().includes('[ERR]') || data.toString().includes('error')) { |
There was a problem hiding this comment.
This looks really fragile. Would be better to check exit code.
There was a problem hiding this comment.
Then where it should resolve?
There was a problem hiding this comment.
In the subprocess exit handler.
There was a problem hiding this comment.
But hyprpaper must always work in background
There was a problem hiding this comment.
I assume it exits if it encounters an error?
There was a problem hiding this comment.
Yes. But I think at error we should reject promise not resolve.
There was a problem hiding this comment.
I never said it should not reject.
|
Commenting this for a second time: #99 (comment) |
|
Also, please open an issue on https://github.com/hyprwm/hyprpaper to provide this info in a machine readable-format like JSON. It's ridiculous having to parse this manually. |
| const formattedQuery = query.split('\n').slice(0, -1).map(row => [row.split('=')[0], row.split('=')[1].trim()]); | ||
| const fallBackImage = formattedQuery.find(row => row[0] === ' ')[1]; | ||
|
|
||
| if (fallBackImage) { |
There was a problem hiding this comment.
| if (fallBackImage) { | |
| if (fallbackImage) { |
Add hyprpaper support